PMD Results

The following document contains the results of PMD 3.7.

Files

atg/adapter/gsa/xml/ImportFailedItem.java

ViolationLine
This statement may have some unnecessary parentheses29
This statement may have some unnecessary parentheses41
This statement may have some unnecessary parentheses53
This statement may have some unnecessary parentheses65
This statement may have some unnecessary parentheses77
Avoid unnecessary constructors - the compiler will generate these for you85 - 87

atg/adapter/gsa/xml/ImportFileParser.java

ViolationLine
Perhaps 'mParser' could be replaced by a local variable.44
It is a good practice to call super() in a constructor60 - 64
A method should have only one exit point, and that should be the last statement in the method86
This statement may have some unnecessary parentheses86
A method should have only one exit point, and that should be the last statement in the method91
This statement may have some unnecessary parentheses91
A method should have only one exit point, and that should be the last statement in the method105
This statement may have some unnecessary parentheses105
A method should have only one exit point, and that should be the last statement in the method110
This statement may have some unnecessary parentheses110
This statement may have some unnecessary parentheses118
Assigning an Object to null is a code smell. Consider refactoring.213

atg/adapter/gsa/xml/ImportItem.java

ViolationLine
This statement may have some unnecessary parentheses31
This statement may have some unnecessary parentheses43
This statement may have some unnecessary parentheses55
This statement may have some unnecessary parentheses67
This statement may have some unnecessary parentheses79
Avoid unnecessary constructors - the compiler will generate these for you87 - 89

atg/adapter/gsa/xml/ImportWorkerThread.java

ViolationLine
Perhaps 'context' could be replaced by a local variable.61
Use explicit scoping instead of the default package private level71
Use explicit scoping instead of the default package private level72
It is a good practice to call super() in a constructor79 - 92
Avoid unnecessary return statements203
This statement may have some unnecessary parentheses372
Avoid empty if statements434
A method should have only one exit point, and that should be the last statement in the method499
Assigning an Object to null is a code smell. Consider refactoring.628
Avoid empty catch blocks688 - 690

atg/adapter/gsa/xml/ReferenceItem.java

ViolationLine
This statement may have some unnecessary parentheses43
This statement may have some unnecessary parentheses53
This statement may have some unnecessary parentheses63

atg/adapter/gsa/xml/ReferenceItemGenerator.java

ViolationLine
Use explicit scoping instead of the default package private level90
Use explicit scoping instead of the default package private level91
Avoid unnecessary return statements235
A method should have only one exit point, and that should be the last statement in the method291
This statement may have some unnecessary parentheses663
This statement may have some unnecessary parentheses813
Assigning an Object to null is a code smell. Consider refactoring.854
Assigning an Object to null is a code smell. Consider refactoring.855
Avoid empty catch blocks1083 - 1085

atg/epub/ImportService.java

ViolationLine
Perhaps 'mAssetsPerSecondIncludingCheckin' could be replaced by a local variable.608
Avoid unnecessary constructors - the compiler will generate these for you618 - 620
It is a good practice to call super() in a constructor618 - 620
Assigning an Object to null is a code smell. Consider refactoring.647
Assigning an Object to null is a code smell. Consider refactoring.648
Assigning an Object to null is a code smell. Consider refactoring.649
Assigning an Object to null is a code smell. Consider refactoring.650
Assigning an Object to null is a code smell. Consider refactoring.655
A method should have only one exit point, and that should be the last statement in the method730
This statement may have some unnecessary parentheses730
A method should have only one exit point, and that should be the last statement in the method757
This statement may have some unnecessary parentheses757
A method should have only one exit point, and that should be the last statement in the method771
This statement may have some unnecessary parentheses771
A method should have only one exit point, and that should be the last statement in the method782
This statement may have some unnecessary parentheses782
A method should have only one exit point, and that should be the last statement in the method806
This statement may have some unnecessary parentheses806
A method should have only one exit point, and that should be the last statement in the method814
This statement may have some unnecessary parentheses814
This statement may have some unnecessary parentheses885
Avoid unnecessary return statements899
A method should have only one exit point, and that should be the last statement in the method964
A method should have only one exit point, and that should be the last statement in the method973
A method should have only one exit point, and that should be the last statement in the method1021
This statement may have some unnecessary parentheses1021
A method should have only one exit point, and that should be the last statement in the method1030
This statement may have some unnecessary parentheses1030
A method should have only one exit point, and that should be the last statement in the method1043
This statement may have some unnecessary parentheses1043
A method should have only one exit point, and that should be the last statement in the method1072
This statement may have some unnecessary parentheses1072
A method should have only one exit point, and that should be the last statement in the method1105
This statement may have some unnecessary parentheses1105
A method should have only one exit point, and that should be the last statement in the method1127
This statement may have some unnecessary parentheses1127
A method should have only one exit point, and that should be the last statement in the method1141
This statement may have some unnecessary parentheses1141
A method should have only one exit point, and that should be the last statement in the method1167
This statement may have some unnecessary parentheses1167
This statement may have some unnecessary parentheses1171
This statement may have some unnecessary parentheses1230
Avoid unnecessary return statements1256
A method should have only one exit point, and that should be the last statement in the method1298
This statement may have some unnecessary parentheses1298
This statement may have some unnecessary parentheses1329
Avoid unnecessary return statements1361
Avoid empty catch blocks1407 - 1410
Avoid empty catch blocks1411 - 1414
Avoid empty catch blocks1426 - 1428
A method should have only one exit point, and that should be the last statement in the method1472
This statement may have some unnecessary parentheses1472
A method should have only one exit point, and that should be the last statement in the method1482
This statement may have some unnecessary parentheses1482
Avoid assigments in operands1491 - 1641
This statement may have some unnecessary parentheses1711
A method should have only one exit point, and that should be the last statement in the method1729
This statement may have some unnecessary parentheses1729
This statement may have some unnecessary parentheses1732
Avoid empty catch blocks1797 - 1799
Avoid empty catch blocks1810 - 1812
A method should have only one exit point, and that should be the last statement in the method1830
This statement may have some unnecessary parentheses1830
A method should have only one exit point, and that should be the last statement in the method1861
This statement may have some unnecessary parentheses1861
A method should have only one exit point, and that should be the last statement in the method1883
This statement may have some unnecessary parentheses1883
This statement may have some unnecessary parentheses1890
A method should have only one exit point, and that should be the last statement in the method1904
This statement may have some unnecessary parentheses1904
A method should have only one exit point, and that should be the last statement in the method1926
This statement may have some unnecessary parentheses1926
This statement may have some unnecessary parentheses1933
A method should have only one exit point, and that should be the last statement in the method1945
This statement may have some unnecessary parentheses1945
A method should have only one exit point, and that should be the last statement in the method1956
This statement may have some unnecessary parentheses1956
This statement may have some unnecessary parentheses1959
A method should have only one exit point, and that should be the last statement in the method1971
This statement may have some unnecessary parentheses1971
This statement may have some unnecessary parentheses1974